-
Notifications
You must be signed in to change notification settings - Fork 327
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Parsing sql for operation name #1013
Parsing sql for operation name #1013
Conversation
Thanks for the PR 🎉 We'll take a look at it and drop feedback here, but we're swamped for the next couple of days so you'll have to be a bit patient! |
So, this looks great, and we'd like to merge it. What do you say, are you up for it? :D |
Yeah I'll mess with it a bit as I get some time. The one thing I wanted to do was to add a cache of statements, but wasn't sure how to add guava and have it be shaded (i don't think I'm shading the sql parser either). But maybe that can be done after we see the performance impact |
I think guava might be a bit overkill, a simple TrieMap might be better. |
0a04586
to
95cc7da
Compare
95cc7da
to
d6ed380
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good for now, I'll test it later today/tomorrow and come back with some more feedback (if necessary)
This is about 90% done! |
@SimunKaracic Feel free to finish it. I'm not sure when I'll have time but it probably won't be for a week or so. |
56db2f5
to
1dc3243
Compare
No description provided.