Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Future instrumentation rollback #1035

Merged
merged 1 commit into from
Jun 4, 2021

Conversation

ivantopo
Copy link
Contributor

@ivantopo ivantopo commented Jun 3, 2021

This PR rolls back the Future Chaining Instrumentation we introduced on Kamon 2.x, and goes back to the same behavior we had on Kamon 1.x. All the Kamon 2.x instrumentation is kept, but deprecated and disabled by defaults, but users could enable them manually if necessary via configuration.

This is expected to be released with Kamon 2.2.0, and requires #1033 and #1034 to be merged first.

For reference, if anybody wanted to enable the Future Chaining instrumentation in 2.2.0+ they would need to add these settings:

kanela.modules {
  executor-service {
    exclude += "scala.concurrent.impl.*"
  }

  scala-future {
    enabled = true
  }
  
  akka-http {
    instrumentations += "kamon.instrumentation.akka.http.FastFutureInstrumentation"
  }  
}

All the code related to the Future Chaining instrumentation will be removed in Kamon 2.3.0.

@ivantopo ivantopo force-pushed the future-instrumentation-rollback branch from e5b52c0 to 592c371 Compare June 4, 2021 09:08
@ivantopo ivantopo marked this pull request as ready for review June 4, 2021 09:08
@SimunKaracic SimunKaracic self-requested a review June 4, 2021 12:57
Copy link
Contributor

@SimunKaracic SimunKaracic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, great job 🎉

@ivantopo ivantopo merged commit e0844b7 into kamon-io:master Jun 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants