Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Propagate the current span id, not the parent span id, according to the spec.
When reading from headers, don't generate a new ID for the Remote span, but use the existing one.
This is the thread where @dguggemos reported the bug -> https://gitter.im/kamon-io/Kamon?at=60cc4e2cb31731135437e0aa
@pnerg If you have the time, check this out. You initially changed this to use the parentID instead of the spanID. According to the W3C spec, the current span ID should be propagated.
From the spec https://www.w3.org/TR/trace-context/#a-traceparent-is-received:
Update parent-id: The value of property parent-id MUST be set to a value representing the ID of the current operation.
#986 I believe this issue originated from the fact that akka-http was being double instrumented.