Add jvm threads states metrics #1075
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ivantopo
requested changes
Nov 17, 2021
There was a problem hiding this comment.
Hey @getArtemUsername, thanks a lot for this addition! The metric and logic looks all fine, there is only a little change on names and descriptions. I'll merge this as soon as those changes are in 😄
...mon-system-metrics/src/main/scala/kamon/instrumentation/system/jvm/JvmMetricsCollector.scala
Outdated
Show resolved
Hide resolved
...tation/kamon-system-metrics/src/main/scala/kamon/instrumentation/system/jvm/JvmMetrics.scala
Outdated
Show resolved
Hide resolved
…rumentation/system/jvm/JvmMetrics.scala Co-authored-by: Ivan Topolnjak <ivantopo@gmail.com>
ivantopo
reviewed
Nov 17, 2021
...mon-system-metrics/src/main/scala/kamon/instrumentation/system/jvm/JvmMetricsCollector.scala
Outdated
Show resolved
Hide resolved
ivantopo
requested changes
Nov 17, 2021
|
@ivantopo Do I need to do something else to be merged? Looks like it's not in 2.4.0 🤔 |
|
Oh man, I even included it in the release notes. I'm sorry. In my head this was merged already 😭 I'll release 2.4.1 right after, including this PR. |
|
Thanks 😄 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, I think that states of threads could be usefull for gross analyzing in cloud environments such as k8s or similar, for example for fine tuning pools or understanding what happens while cpu throttling.