Make it easier to expose Prometheus metrics on custom endpints #1079
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It often happens that people want to expose the Prometheus scrape data on their own HTTP server and the only way to do it so far is to:
kamon.modules.prometheus-reporter.enabled=false
Kamon.addReporter(...)
, and keep a reference to the reporterprometheusReporter.scrapeData()
and return that on the HTTP serverIt is kind of annoying. Since we know that in most cases there is only one PrometheusReporter instance created automatically by Kamon, this PR ensures that we keep a reference to that instance and expose it's scrape data via
PrometheusReporter.latestScrapeData()
, so that users can skip all the above when they need to.