Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make adding the db.statement tag configurable in jdbc calls #1103

Merged
merged 2 commits into from
Feb 11, 2022

Conversation

ivantopo
Copy link
Contributor

@ivantopo ivantopo commented Feb 8, 2022

This PR makes it possible to decide whether the db.statement tag is going to be added to spans created by the JDBC instrumentation. There are three possible settings:

  • always: (default) will always add the db.statement tag to spans
  • prepared: will only add the the db.statement tag when the traced execution was made with a PreparedStatement, which should ensure no placeholder values are leaked to the tracing backend
  • never: completely disables adding the db.statement tag to spans

@ivantopo ivantopo merged commit aa6c127 into kamon-io:master Feb 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant