DataDog Trace HTTP Propagation #1145
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Sean Glover <sean@seanglover.com> Co-authored-by: Leonard Law <leon.wlaw@gmail.com>
seglo
force-pushed
the
seglo/datadog-http-propagation
branch
from
1ef14f3 to
840e0c5
Compare
ivantopo
reviewed
Mar 29, 2022
ivantopo
reviewed
Mar 29, 2022
core/kamon-core-tests/src/test/scala/kamon/trace/DataDogSpanPropagationSpec.scala
Outdated
Show resolved
Hide resolved
|
Hey @seglo, thanks for implementing this! Overall it looks great. If you have a chance to fix the typo before Friday please do, otherwise I'll do it and merge the PR so it makes it to the next release 💪 |
|
Excellent. Thanks for the review @ivantopo. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ref: #1031
Basic DataDog HTTP Propagation. This does not include support for other headers the
dd-trace-javalibrary supports includingot-baggage-prefixed headers andx-datadog-origin. I think it could be added simply, but we don't use either header in our solutions ATM.I also want to give credit to my colleague for his contributions @linkleonard