Alpakka producer context propagation #1168
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ihostage
reviewed
May 23, 2022
ivantopo
force-pushed
the
alpakka-producer-context-propagation
branch
3 times, most recently
from
a921b5a to
05a577e
Compare
ivantopo
force-pushed
the
alpakka-producer-context-propagation
branch
from
05a577e to
b76d2b9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR brings instrumentation that propagates context from the place where
ProducerMessageinstances are created (either Message or MultiMessage) to the place where the actual Kafka Producer API is called, usually behindProducer.flow,Producer.flexiFlow, orProducer.committableSink.This will ensure that the proper context is written to the Kafka messages and that those produce spans will be shown in the traces as well!