Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

propagate context when handling unary Akka gRPC server requests #1229

Conversation

ivantopo
Copy link
Contributor

This PR ensures that context (including the HTTP Server Span) that we create automatically on the Akka HTTP instrumentation will get propagated to the service implementation calls.

Notes:

  • It only works with unary requests. Stream-based requests will still require manual handling by users.
  • The culprit of this issue is that CompletionStage is not instrumented at all and the Java-based version of Akka gRPC uses completable futures in a few places. Writing instrumentation for CompletionStage might be enough to remove this instrumentation in the future.

@ivantopo ivantopo merged commit 363d038 into kamon-io:master Nov 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant