propagate context when handling unary Akka gRPC server requests #1229
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR ensures that context (including the HTTP Server Span) that we create automatically on the Akka HTTP instrumentation will get propagated to the service implementation calls.
Notes:
CompletionStage
is not instrumented at all and the Java-based version of Akka gRPC uses completable futures in a few places. Writing instrumentation forCompletionStage
might be enough to remove this instrumentation in the future.