Discoverable modules and the new module registry #559
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@ivantopo awesome man!!! |
dpsoft
reviewed
Oct 16, 2018
| @@ -46,8 +46,9 @@ lazy val core = (project in file("kamon-core")) | |||
| .settings( | |||
| libraryDependencies ++= Seq( | |||
| "com.typesafe" % "config" % "1.3.1", | |||
| "org.slf4j" % "slf4j-api" % "1.7.25", | |||
| "org.hdrhistogram" % "HdrHistogram" % "2.1.9" | |||
| "org.hdrhistogram" % "HdrHistogram" % "2.1.9", | |||
There was a problem hiding this comment.
I think that in a near future we need shade HDR and JCTools. WDYT?
There was a problem hiding this comment.
Totally agree. I remember we had an issue with users having a different version of the HDR histogram in the classpath already. That we can do before releasing.
|
I noticed the compilation error, but it seems like travis is somehow stuck on a previous version.. if you look at the branch, that is not the code that is there: https://github.com/ivantopo/Kamon/blob/modules/kamon-core/src/main/scala/kamon/trace/SpanPropagation.scala#L130 |
|
@ivantopo LGTM! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR brings back something we had back in Kamon 0.6.x: the ability to discover modules by simply having them in the classpath. From this point on, calling
Kamon.loadModules()will pick everything under thekamon.modulesconfiguration and try to start them.We didn't have the actual "modules" concept in 1.x, only reporters were available but with this PR the MetricReporter and SpanReporter traits are just a special type of module. Soon we should be moving things like the executor metrics collectors and JVM/host metrics to modules so that we can globally control their lifecycle and allow a "drop a jar" installation method :).
Also deprecated the "addReporter" variants but kept them compatible.