Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Warning cleanup #600

Merged
merged 5 commits into from
Aug 9, 2019
Merged

Warning cleanup #600

merged 5 commits into from
Aug 9, 2019

Conversation

melezov
Copy link
Contributor

@melezov melezov commented Jul 28, 2019

Run some static code analysis - seems to have found a buggy with config param.
Other stuff is just making linters happy.

Scream if you want me to exclude / squash commits.

melezov added 4 commits July 28, 2019 15:26
SuperSafe: Remove usage of .equals
Scalafix: remove unused imports & private hex function

There is no need to guard against LHS null in Scala equality and isInstanceOf
@ivantopo ivantopo merged commit 2a9c979 into kamon-io:master Aug 9, 2019
@ivantopo
Copy link
Contributor

ivantopo commented Aug 9, 2019

Thanks a lot @melezov! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants