Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#563 Kamon on Lagom projects #760

Merged
merged 1 commit into from
Jan 25, 2022
Merged

Conversation

ihostage
Copy link
Contributor

@ihostage ihostage commented Apr 2, 2020

@thanidev
Copy link

Hi @ihostage any update on this?

@ihostage
Copy link
Contributor Author

Hi @thanidev! I wait for the review of maintainers 😄

@SimunKaracic
Copy link
Contributor

Yeah this one fell through the cracks :(
I promise to give it a look next week

@SimunKaracic
Copy link
Contributor

Thanks for the patience, but it looks like you'll have to wait a bit more.
The reason this PR is waiting is: we don't know a lot about Lagom.

Before we can merge this, we'd have to try it (Lagom) out, see how other people are using it, make sure the metrics make sense and are named/tagged correctly, etc...

Don't worry, we're going to give Lagom some love in the future, but we have some other priorities right now.

@thanidev
Copy link

Thanks for the patience, but it looks like you'll have to wait a bit more.

If Kamon support all akka projects like Play or Lagom, it will be nice..

@ihostage ihostage force-pushed the issues/563 branch 2 times, most recently from e2d5377 to f39b282 Compare May 31, 2021 13:57
@ihostage ihostage force-pushed the issues/563 branch 2 times, most recently from e4957c7 to 91158ef Compare October 26, 2021 18:48
@ihostage
Copy link
Contributor Author

Together with kamon-prometheus the metrics for one breaker looks like this:

# HELP lagom_cb_count_total Count of calls of Lagom Circuit Breakers
# TYPE lagom_cb_count_total counter
lagom_cb_count_total{component="lagom",success="true",cb="circuit-breaker-name"} 4.0
lagom_cb_count_total{cb="circuit-breaker-name",fail="timeout",component="lagom",success="false"} 0.0
lagom_cb_count_total{component="lagom",success="false",cb="circuit-breaker-name"} 0.0
lagom_cb_count_total{cb="circuit-breaker-name",fail="open",component="lagom",success="false"} 0.0

# HELP lagom_cb_state State of Lagom Circuit Breakers
# TYPE lagom_cb_state gauge
lagom_cb_state{component="lagom",cb="circuit-breaker-name"} 0.0

# HELP lagom_cb_latency_seconds Latency of Lagom Circuit Breakers
# TYPE lagom_cb_latency_seconds histogram
lagom_cb_latency_seconds_bucket{le="0.005",component="lagom",cb="circuit-breaker-name"} 0.0
lagom_cb_latency_seconds_bucket{le="0.01",component="lagom",cb="circuit-breaker-name"} 0.0
lagom_cb_latency_seconds_bucket{le="0.025",component="lagom",cb="circuit-breaker-name"} 0.0
lagom_cb_latency_seconds_bucket{le="0.05",component="lagom",cb="circuit-breaker-name"} 0.0
lagom_cb_latency_seconds_bucket{le="0.075",component="lagom",cb="circuit-breaker-name"} 0.0
lagom_cb_latency_seconds_bucket{le="0.1",component="lagom",cb="circuit-breaker-name"} 2.0
lagom_cb_latency_seconds_bucket{le="0.25",component="lagom",cb="circuit-breaker-name"} 3.0
lagom_cb_latency_seconds_bucket{le="0.5",component="lagom",cb="circuit-breaker-name"} 3.0
lagom_cb_latency_seconds_bucket{le="0.75",component="lagom",cb="circuit-breaker-name"} 3.0
lagom_cb_latency_seconds_bucket{le="1.0",component="lagom",cb="circuit-breaker-name"} 4.0
lagom_cb_latency_seconds_bucket{le="2.5",component="lagom",cb="circuit-breaker-name"} 4.0
lagom_cb_latency_seconds_bucket{le="5.0",component="lagom",cb="circuit-breaker-name"} 4.0
lagom_cb_latency_seconds_bucket{le="7.5",component="lagom",cb="circuit-breaker-name"} 4.0
lagom_cb_latency_seconds_bucket{le="10.0",component="lagom",cb="circuit-breaker-name"} 4.0
lagom_cb_latency_seconds_bucket{le="+Inf",component="lagom",cb="circuit-breaker-name"} 4.0
lagom_cb_latency_seconds_count{component="lagom",cb="circuit-breaker-name"} 4.0
lagom_cb_latency_seconds_sum{component="lagom",cb="circuit-breaker-name"} 1.099431936

# HELP lagom_cb_timer_seconds Timer of calls of Lagom Circuit Breakers
# TYPE lagom_cb_timer_seconds histogram
lagom_cb_timer_seconds_bucket{cb="circuit-breaker-name",le="0.005",component="lagom",success="true"} 0.0
lagom_cb_timer_seconds_bucket{cb="circuit-breaker-name",le="0.01",component="lagom",success="true"} 0.0
lagom_cb_timer_seconds_bucket{cb="circuit-breaker-name",le="0.025",component="lagom",success="true"} 0.0
lagom_cb_timer_seconds_bucket{cb="circuit-breaker-name",le="0.05",component="lagom",success="true"} 0.0
lagom_cb_timer_seconds_bucket{cb="circuit-breaker-name",le="0.075",component="lagom",success="true"} 0.0
lagom_cb_timer_seconds_bucket{cb="circuit-breaker-name",le="0.1",component="lagom",success="true"} 2.0
lagom_cb_timer_seconds_bucket{cb="circuit-breaker-name",le="0.25",component="lagom",success="true"} 3.0
lagom_cb_timer_seconds_bucket{cb="circuit-breaker-name",le="0.5",component="lagom",success="true"} 3.0
lagom_cb_timer_seconds_bucket{cb="circuit-breaker-name",le="0.75",component="lagom",success="true"} 3.0
lagom_cb_timer_seconds_bucket{cb="circuit-breaker-name",le="1.0",component="lagom",success="true"} 4.0
lagom_cb_timer_seconds_bucket{cb="circuit-breaker-name",le="2.5",component="lagom",success="true"} 4.0
lagom_cb_timer_seconds_bucket{cb="circuit-breaker-name",le="5.0",component="lagom",success="true"} 4.0
lagom_cb_timer_seconds_bucket{cb="circuit-breaker-name",le="7.5",component="lagom",success="true"} 4.0
lagom_cb_timer_seconds_bucket{cb="circuit-breaker-name",le="10.0",component="lagom",success="true"} 4.0
lagom_cb_timer_seconds_bucket{cb="circuit-breaker-name",le="+Inf",component="lagom",success="true"} 4.0
lagom_cb_timer_seconds_count{component="lagom",success="true",cb="circuit-breaker-name"} 4.0
lagom_cb_timer_seconds_sum{component="lagom",success="true",cb="circuit-breaker-name"} 1.099431936

@ivantopo ivantopo merged commit ea89ffa into kamon-io:master Jan 25, 2022
@ihostage ihostage deleted the issues/563 branch January 25, 2022 16:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants