Add Kamon.stop method #804
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jtjeferreira
commented
Jul 6, 2020
core/kamon-core/src/main/scala/kamon/module/ModuleRegistry.scala
Outdated
Show resolved
Hide resolved
jtjeferreira
force-pushed
the
stop_kamon
branch
3 times, most recently
from
65de6b3 to
08cde9c
Compare
jtjeferreira
commented
Dec 11, 2020
| import com.typesafe.config.{Config, ConfigUtil} | ||
|
|
||
| import scala.collection.concurrent.TrieMap | ||
|
|
||
| package object kamon { | ||
|
|
||
| def newScheduledThreadPool(corePoolSize: Int, threadFactory: ThreadFactory): ScheduledExecutorService = { |
There was a problem hiding this comment.
@ivantopo this will make the threads stop if there is no more work in the queues. I got this from https://github.com/typelevel/cats-effect/blob/series/2.x/core/jvm/src/main/scala/cats/effect/internals/IOTimer.scala#L72-L98.
Do you think we should make this configurable instead?
There was a problem hiding this comment.
I wouldn't make it configurable unless there was an effect to end users. For now, leave it as it is.
| @@ -39,8 +39,9 @@ import scala.util.control.NonFatal | |||
| class ModuleRegistry(configuration: Configuration, clock: Clock, metricRegistry: MetricRegistry, tracer: Tracer) { | |||
|
|
|||
| private val _logger = LoggerFactory.getLogger(classOf[ModuleRegistry]) | |||
| private val _metricsTickerExecutor = Executors.newScheduledThreadPool(1, threadFactory("kamon-metrics-ticker", daemon = true)) | |||
| private val _spansTickerExecutor = Executors.newScheduledThreadPool(1, threadFactory("kamon-spans-ticker", daemon = true)) | |||
| private val _moduleRegistryEC: ExecutionContext = ExecutionContext.fromExecutor(newScheduledThreadPool(1, threadFactory("kamon-module-registry", daemon = true))) | |||
There was a problem hiding this comment.
introduced another EC to be used by shutdown logic...
ivantopo
approved these changes
Jan 29, 2021
There was a problem hiding this comment.
Awesome work @jtjeferreira! We are finally be leak-free in Play development mode 🎉
| @@ -39,8 +39,9 @@ import scala.util.control.NonFatal | |||
| class ModuleRegistry(configuration: Configuration, clock: Clock, metricRegistry: MetricRegistry, tracer: Tracer) { | |||
|
|
|||
| private val _logger = LoggerFactory.getLogger(classOf[ModuleRegistry]) | |||
| private val _metricsTickerExecutor = Executors.newScheduledThreadPool(1, threadFactory("kamon-metrics-ticker", daemon = true)) | |||
| private val _spansTickerExecutor = Executors.newScheduledThreadPool(1, threadFactory("kamon-spans-ticker", daemon = true)) | |||
| private val _moduleRegistryEC: ExecutionContext = ExecutionContext.fromExecutor(newScheduledThreadPool(1, threadFactory("kamon-module-registry", daemon = true))) | |||
| import com.typesafe.config.{Config, ConfigUtil} | ||
|
|
||
| import scala.collection.concurrent.TrieMap | ||
|
|
||
| package object kamon { | ||
|
|
||
| def newScheduledThreadPool(corePoolSize: Int, threadFactory: ThreadFactory): ScheduledExecutorService = { |
There was a problem hiding this comment.
I wouldn't make it configurable unless there was an effect to end users. For now, leave it as it is.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A different approach to #780