Issue 805/fail when cassandra driver is missing #806
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ivantopo
force-pushed
the
issue-805/fail-when-cassandra-driver-is-missing
branch
from
b92a89c to
d06742d
Compare
ivantopo
force-pushed
the
issue-805/fail-when-cassandra-driver-is-missing
branch
from
d06742d to
f94ae39
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm not entirely sure of why these changes fix the issue, but they do 🤷
My theory is that the advices were pulling references to the Cassandra Driver classes, specially when inlining. But we do have other advices looking very similar to the ones in the driver instrumentation and those don't generate any problems.
I'm going to release this in a few minutes since it could be affecting a lot of people out there.