Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

B3 debug flag fix #823

Merged
merged 2 commits into from
Aug 25, 2020
Merged

B3 debug flag fix #823

merged 2 commits into from
Aug 25, 2020

Conversation

klvmungai
Copy link
Contributor

As per the B3 propagation spec, the debug flag should only be considered if it has a value of 1. This PR rectifies the current logic to ensure that the system falls back to the X-B3-Sampled header if the debug flag holds an invalid value.

@Tochemey
Copy link

@dpsoft and @ivantopo +1 on this PR

@ivantopo
Copy link
Contributor

Hey @klvmungai, @Tochemey, thanks a lot for the PR!

@ivantopo ivantopo merged commit 3016a95 into kamon-io:master Aug 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants