Added support for adding custom HTTP headers to responses #858
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SimunKaracic
approved these changes
Sep 28, 2020
ivantopo
requested changes
Oct 1, 2020
instrumentation/kamon-instrumentation-common/src/main/resources/reference.conf
Outdated
Show resolved
Hide resolved
|
Seems like there's random test failures. |
SimunKaracic
pushed a commit
to SimunKaracic/Kamon
that referenced
this pull request
Oct 15, 2020
perenecabuto
pushed a commit
to globocom/Kamon
that referenced
this pull request
Feb 12, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements the feature request from issue: #857
In essence following the similar pattern as e.g. custom operator naming allowing the developer to provide a FQCN to a class that generates a Map of headers to add to the response.
Default implementation does nothing, i.e. empty Map