fix: ignore doJsonPut failure result #863
Merged
+7
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -12,6 +12,8 @@ import kamon.util.{ EnvironmentTags, Filter } | |||
| import org.slf4j.LoggerFactory | |||
| import play.api.libs.json.{ JsObject, Json } | |||
|
|
|||
| import scala.util.{ Failure, Success } | |||
There was a problem hiding this comment.
Remove unnecessary Success import
SimunKaracic
approved these changes
Sep 28, 2020
|
Thanks a lot for the fix @ryota0624! |
perenecabuto
pushed a commit
to globocom/Kamon
that referenced
this pull request
Feb 12, 2021
* fix: ignore doJsonPut failure result * remove unnecessary import
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
i fixed
httpClient.doJsonPutresultTry's Failure case ignored.threw exception is catched by caller method and Failure case is output to log by this fix.