Fix spans leaking between tests in cassandra instrumentation #865
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SimunKaracic
force-pushed
the
kamon-cassandra-intermittent-test-failures
branch
from
d62297b to
c7ee3d5
Compare
SimunKaracic
commented
Oct 15, 2020
.../scala/kamon/instrumentation/instrumentation/CassandraClientTracingInstrumentationSpec.scala
Show resolved
Hide resolved
SimunKaracic
force-pushed
the
kamon-cassandra-intermittent-test-failures
branch
5 times, most recently
from
96482b7 to
4efaeb5
Compare
SimunKaracic
force-pushed
the
kamon-cassandra-intermittent-test-failures
branch
from
4efaeb5 to
9483726
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before these fixes, failures would occur ~1/15 times.
To test this, I ran the tests 100 times without any failures.
Hopefully, that's the last of them in this module.