Fix for issues #872 and #860 #881
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bring back classloading metrics that were forgotten during migration. Express memory/swap/disk usage as percentage, simplifying some dashboards
ivantopo
requested changes
Oct 28, 2020
...tion/kamon-system-metrics/src/main/scala/kamon/instrumentation/system/host/HostMetrics.scala
Outdated
Show resolved
Hide resolved
...tion/kamon-system-metrics/src/main/scala/kamon/instrumentation/system/host/HostMetrics.scala
Outdated
Show resolved
Hide resolved
...tion/kamon-system-metrics/src/main/scala/kamon/instrumentation/system/host/HostMetrics.scala
Outdated
Show resolved
Hide resolved
...tation/kamon-system-metrics/src/main/scala/kamon/instrumentation/system/jvm/JvmMetrics.scala
Outdated
Show resolved
Hide resolved
...mon-system-metrics/src/main/scala/kamon/instrumentation/system/jvm/JvmMetricsCollector.scala
Outdated
Show resolved
Hide resolved
ivantopo
approved these changes
Nov 2, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Bring back classloading metrics that were forgotten during migration.
Express memory/swap/disk usage as percentage, simplifying some
dashboards.
Various formatting fixes as I dig around old files.
Open questions:
What default tags should be used for classloading metrics?
I kept the old defaults (
component -> system-metrics), butcomponent -> jvmalso makes sense.Should there be a setting to turn any of these metrics on/off?