Datadog 'Deflate' compression #929
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Great PR, merge-ing as is! Thanks for the contribution 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces 'Deflate' compression when
POSTing to the Datadog API. The Datadog API is known to have a payload limit (see https://docs.datadoghq.com/api/latest/metrics/#submit-metrics). By using compression, users canPOSTbodies which are larger in size than this limit.Compression has been made optional, under the
datadog.api.compressionkey.We ran into the Datadog limit when posting metrics for one of our services. This was resolved by using this 'Deflate' compression functionality. Note that the Datadog API doesn't support gzip compression, as we attempted this compression method before.