Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Kafka Consumer instrumentation issue #947

Merged
merged 1 commit into from
Feb 24, 2021

Conversation

mladens
Copy link
Contributor

@mladens mladens commented Feb 16, 2021

Handle case where consumer has no group.id set.
In one particular case, globalConsumer used by KafkaStreams when restoring global state.

Handle case where consumer has no group.id set.
In particular, case of a globalConsumer used by  KafkaStreams when
restoring global stores.
@mladens mladens requested a review from SimunKaracic February 16, 2021 14:41
Copy link
Contributor

@SimunKaracic SimunKaracic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🚀

@SimunKaracic SimunKaracic merged commit a0f9827 into kamon-io:master Feb 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants