Basic spring boot support #948
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SimunKaracic
force-pushed
the
basic-spring-boot-support
branch
from
950768c to
3085294
Compare
SimunKaracic
force-pushed
the
basic-spring-boot-support
branch
from
3085294 to
c2b4f75
Compare
ivantopo
requested changes
Mar 8, 2021
.../kamon-spring/src/main/scala/kamon/instrumentation/spring/client/ClientInstrumentation.scala
Outdated
Show resolved
Hide resolved
.../kamon-spring/src/main/scala/kamon/instrumentation/spring/client/ClientInstrumentation.scala
Outdated
Show resolved
Hide resolved
...ring/src/main/scala/kamon/instrumentation/spring/client/SpringWebClientInstrumentation.scala
Outdated
Show resolved
Hide resolved
...entation/kamon-spring/src/main/java/kamon/instrumentation/spring/server/CallableWrapper.java
Outdated
Show resolved
Hide resolved
...mon-spring/src/main/scala/kamon/instrumentation/spring/server/HasServerInstrumentation.scala
Outdated
Show resolved
Hide resolved
...mon-spring/src/main/scala/kamon/instrumentation/spring/server/SpringMVCInstrumentation.scala
Outdated
Show resolved
Hide resolved
...mon-spring/src/main/scala/kamon/instrumentation/spring/server/SpringMVCInstrumentation.scala
Outdated
Show resolved
Hide resolved
...mon-spring/src/main/scala/kamon/instrumentation/spring/server/SpringMVCInstrumentation.scala
Outdated
Show resolved
Hide resolved
...mon-spring/src/main/scala/kamon/instrumentation/spring/server/SpringMVCInstrumentation.scala
Outdated
Show resolved
Hide resolved
and a few other driveby cleanups (removing comments, correct config calls)
Removed because it was not available in earlier versions of Spring
With some smaller refactors, options turned to null checks, and others
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add basic spring-boot support for servers using spring-mvc.
If you see a comment, it's either a reminder for me or a comment for you
I've tested this with multiple, albeit simple apps.
It worked with mvn and gradle packaging 🎉