Revert passivate tracking to fix #944 #959
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The problem here is that it's very hard to replicate the error locally.
Since it's just a simple revert, it'll go out in the next release, but I'd sleep better at night if someone (who can reproduce this not in prod) were to try this out on an app that's currently showing the bug
If you're up for it, checkout this branch, start sbt and do the following:
or if you're using maven
and add the kamon version
944-fix
to you app :)