Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert passivate tracking to fix #944 #959

Merged

Conversation

SimunKaracic
Copy link
Contributor

The problem here is that it's very hard to replicate the error locally.
Since it's just a simple revert, it'll go out in the next release, but I'd sleep better at night if someone (who can reproduce this not in prod) were to try this out on an app that's currently showing the bug

If you're up for it, checkout this branch, start sbt and do the following:

set version in ThisBuild := "944-fix"
+publishLocal

or if you're using maven

set version in ThisBuild := "944-fix"
+publishM2

and add the kamon version 944-fix to you app :)

Also bump akka 2.5 version
@SimunKaracic SimunKaracic requested a review from ivantopo March 17, 2021 11:52
@SimunKaracic SimunKaracic merged commit daa9e4d into kamon-io:master Mar 18, 2021
@SimunKaracic SimunKaracic deleted the 944-re-add-instrumentation-for-2.5 branch March 18, 2021 11:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant