(status page) Add missing api key state #969
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add a special state for Kamon APM reporter that guides the user in case their API key is not configured or is invalid. Update Typescript and underscore to allow for modern dev practices.
| :key="reporter.name" | ||
| :module="reporter" | ||
| :is-missing-key="isMisconfiguredApmModule(reporter)" | ||
| /> | ||
| <div v-if="!hasApmModule" class="apm-suggestion"> | ||
| <a href="https://kamon.io/apm/?utm_source=kamon&utm_medium=status-page&utm_campaign=kamon-status" target="_blank"> |
There was a problem hiding this comment.
While touching, want me to change this, @ivantopo?
Do a best guess for which integration we're using to toggle the upcoming "continue onboarding" flow where the service name and the correct framework/lib (best we can tell) are pre-filled and the user just has to copy-paste their configuration or API key.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a special state for Kamon APM reporter that guides the user in case
their API key is not configured or is invalid.
Update Typescript and underscore to allow for modern dev practices.
The link itself will change once we have the new onboarding. We could wait to merge this until then.