Update Azure SDK Libraries in Kanister #2326
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pavannd1
reviewed
Sep 12, 2023
go.mod
Outdated
Comment on lines
203
to
205
| require ( | ||
| github.com/Azure/azure-sdk-for-go/sdk/azidentity v1.3.1 // indirect | ||
| github.com/AzureAD/microsoft-authentication-library-for-go v1.2.0 // indirect | ||
| github.com/golang-jwt/jwt/v5 v5.0.0 // indirect | ||
| github.com/kylelemons/godebug v1.1.0 // indirect | ||
| github.com/pkg/browser v0.0.0-20210911075715-681adbf594b8 // indirect | ||
| ) |
There was a problem hiding this comment.
We should move this into the group of indirect modules above
pkg/blockstorage/azure/azuredisk.go
Outdated
| azcompute "github.com/Azure/azure-sdk-for-go/services/compute/mgmt/2019-03-01/compute" | ||
| "github.com/Azure/azure-sdk-for-go/storage" | ||
| azto "github.com/Azure/go-autorest/autorest/to" | ||
| helper "github.com/kanisterio/kanister/pkg/blockstorage" |
There was a problem hiding this comment.
Suggested change
| helper "github.com/kanisterio/kanister/pkg/blockstorage" |
This is not required. It's already imported on line 24. You can replace helper.* to blockstorage.*
pkg/blockstorage/azure/client.go
Outdated
Comment on lines
23
to
24
| "github.com/Azure/go-autorest/autorest" | ||
| "github.com/Azure/go-autorest/autorest/azure/auth" |
There was a problem hiding this comment.
Looks like VSCode added these back. The client code could still be using these libraries.
mabhi
force-pushed
the
update-azure-sdk-libraries
branch
2 times, most recently
from
f654795
to
5c4b810
Compare
Signed-off-by: mabhi <abhijit.mukherjee@infracloud.io>
Signed-off-by: mabhi <abhijit.mukherjee@infracloud.io>
Signed-off-by: mabhi <abhijit.mukherjee@infracloud.io>
Signed-off-by: mabhi <abhijit.mukherjee@infracloud.io>
Signed-off-by: mabhi <abhijit.mukherjee@infracloud.io>
Signed-off-by: mabhi <abhijit.mukherjee@infracloud.io>
mabhi
force-pushed
the
update-azure-sdk-libraries
branch
from
f929bca
to
b853319
Compare
|
moving to #2368 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Overview
As per Azure guidelines, few modules from azure library are retiring support from 31 March 2023 . Due to which there is need to replace such modules with azure recommended azure-go-sdk modules.
go-autorestbeing used in theblockstoragepackage will be out of support from March 2023. Follow the documentation below to replace it with a new supported package.https://azure.microsoft.com/en-us/updates/support-for-azure-sdk-libraries-that-do-not-conform-to-our-current-azure-sdk-guidelines-will-be-retired-as-of-31-march-2023/
Pull request type
Please check the type of change your PR introduces:
Issues
Test Plan