Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update minio helm chart link #2502

Merged
merged 2 commits into from
Dec 1, 2023
Merged

Update minio helm chart link #2502

merged 2 commits into from
Dec 1, 2023

Conversation

PrasadG193
Copy link
Contributor

@PrasadG193 PrasadG193 commented Nov 30, 2023

Change Overview

Update minio helm chart link to https://charts.min.io/ as documented in the https://github.com/minio/minio/tree/master/helm/minio

Pull request type

Please check the type of change your PR introduces:

  • 🚧 Work in Progress
  • 🌈 Refactoring (no functional changes, no api changes)
  • 🐹 Trivial/Minor
  • 🐛 Bugfix
  • 🌻 Feature
  • 🗺️ Documentation
  • 🤖 Test

Issues

  • fixes #issue-number

Test Plan

  • 💪 Manual
  • ⚡ Unit test
  • 💚 E2E

Signed-off-by: Prasad Ghangal <prasad.ganghal@veeam.com>
Copy link
Contributor

@hairyhum hairyhum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

New link works for me.
Can you document reasoning for environment variable changes please?

@PrasadG193
Copy link
Contributor Author

@hairyhum it's a different chart than what we were using earlier. So older helm flags are not relevant. We are setting the applicable flags now in the build/minio.sh

@mergify mergify bot merged commit c07784b into master Dec 1, 2023
14 checks passed
@mergify mergify bot deleted the update-minio-chart-link branch December 1, 2023 06:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants