Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improved errors, logging and compilation #15

Merged
merged 2 commits into from
Jan 15, 2018

Conversation

ramaro
Copy link
Member

@ramaro ramaro commented Jan 15, 2018

This will log/print friendlier error messages avoiding tracebacks for known failure behaviours:

  • inventory not found
  • inventory render errors
  • jsonnet compile errors
  • jinja2 render errors (including jsonnet native calls)

Thus improving #11

Compiling will also now write to a tempdir and move it to output_path on success (tempdir is always removed)

@ramaro ramaro self-assigned this Jan 15, 2018
@gburiola gburiola merged commit 84d7eb4 into kapicorp:master Jan 15, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants