-
Notifications
You must be signed in to change notification settings - Fork 199
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Helm dependency #520
Helm dependency #520
Conversation
Thanks for the great contribution! Reviewing... |
…ger be necessary for jsonnet binary
…its with a non 0 code
It would be great to include along with this PR an update to https://github.com/deepmind/kapitan/blob/master/docs/kap_proposals/kap_2_helm_charts_input_type.md so that it reflects the new input capabilities after this is merged? |
@uberspot Agreed. I'd like to add to the dependency manger documentation and provide a "complete" helm example in the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@sebradloff can you remove kapitan/dependency_manager/helm/helm_fetch.so
Other than that, this LGTM
@ramaro the helm input has a |
@sebradloff thanks for the great contribution! I also think it's a good idea to gitignore the |
Agree, let's add |
Proposed Changes
helm
. Allows the user to download a helm chart and its subcharts.