Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Helm dependency #520

Merged
merged 17 commits into from
Jun 10, 2020
Merged

Helm dependency #520

merged 17 commits into from
Jun 10, 2020

Conversation

sebradloff
Copy link
Contributor

Proposed Changes

  • Introduces a new external dependency of type helm. Allows the user to download a helm chart and its subcharts.
  • Upgrades to golang 1.14.

@ramaro
Copy link
Member

ramaro commented Jun 8, 2020

Thanks for the great contribution! Reviewing...

@uberspot
Copy link
Contributor

uberspot commented Jun 8, 2020

It would be great to include along with this PR an update to https://github.com/deepmind/kapitan/blob/master/docs/kap_proposals/kap_2_helm_charts_input_type.md so that it reflects the new input capabilities after this is merged?
To make sure it's rolled out at the same time as the code.

@sebradloff
Copy link
Contributor Author

It would be great to include along with this PR an update to https://github.com/deepmind/kapitan/blob/master/docs/kap_proposals/kap_2_helm_charts_input_type.md so that it reflects the new input capabilities after this is merged?
To make sure it's rolled out at the same time as the code.

@uberspot Agreed. I'd like to add to the dependency manger documentation and provide a "complete" helm example in the examples directory.

Copy link
Member

@ramaro ramaro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sebradloff can you remove kapitan/dependency_manager/helm/helm_fetch.so
Other than that, this LGTM

docs/external_dependencies.md Outdated Show resolved Hide resolved
@sebradloff
Copy link
Contributor Author

@sebradloff can you remove kapitan/dependency_manager/helm/helm_fetch.so
Other than that, this LGTM

@ramaro the helm input has a libetemplate.so file checked in as well. Would you like me to gitignore all .so files? The kapitan/dependency_manager/helm/helm_fetch.so is quite large so that seems totally reasonable to not have checked in along with the fact it gets built anyway during the CI steps.

@yoshi-1224
Copy link
Contributor

@sebradloff thanks for the great contribution! I also think it's a good idea to gitignore the .so files as well as all the other auto-generated files (e.g. header files generated by cgo such as libtemplate.h, helm_fetch.h etc.). I didn't update the gitignore file when I was working on helm binding but it makes sense to do so. The rest seems great!

@ramaro
Copy link
Member

ramaro commented Jun 10, 2020

Agree, let's add .so to ignore. Thanks both!

@uberspot uberspot self-requested a review June 10, 2020 15:12
@ramaro ramaro merged commit 899d82b into kapicorp:master Jun 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants