-
Notifications
You must be signed in to change notification settings - Fork 199
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Build multi-arch docker images #944
Conversation
Overall looks good. I've rebased to re-run tests. |
I added some comments in the CI and a paragraph in the README, is it ok ? |
This allow to build the correct image when host plateform is not amd64. Related doc : https://docs.docker.com/build/building/multi-platform/
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good, thank you @antonincms !
Thank you for the review ! |
Fixes issue #939
Proposed Changes
On a M1 / M2 mac the performance are 5x worse for our use case if using the amd64 docker.
We would like to have the possibility of using a multi-plateform image, and this PR allows that :
and then building multi-plateform images of kapitan.
Building an image on a computer of the same architecture should work as previously.
I could add some documentation on how to do locally what the CI does (build a multi-arch image with a single tag).
This was inspired by this bit of documentation about building multi-plateform images : https://docs.docker.com/build/ci/github-actions/examples/#multi-platform-images
There is also this more general documentation about how to set this up outside of CI : https://docs.docker.com/build/building/multi-platform/