Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should Wire be renamed Column? #37

Open
tomjaguarpaw opened this issue Jul 14, 2014 · 8 comments
Open

Should Wire be renamed Column? #37

tomjaguarpaw opened this issue Jul 14, 2014 · 8 comments

Comments

@tomjaguarpaw
Copy link
Collaborator

Column would be a clearer name. Alternatively we could use the abbreviations Col or C.

@ocharles
Copy link
Contributor

👍, Wire is a far too technical term (it only has meaning if you know that you got here from studying wiring diagrams).

@tomjaguarpaw
Copy link
Collaborator Author

Furthermore, the library doesn't especially resemble the wiring diagrams paper anymore!

@tomjaguarpaw
Copy link
Collaborator Author

@ocharles: C, Col or Column?

@ocharles
Copy link
Contributor

I prefer Column.

@tomjaguarpaw
Copy link
Collaborator Author

I'm tempted to say that Column will make type signatures very long. My preference is Col, but I will wait for others to chime in.

@dbp
Copy link
Contributor

dbp commented Jul 16, 2014

I think I'd prefer Column as well. It is longer, but I think it's clearer, and IMO clarity wins over length. If things are truly too long and repeated, well, we have type aliases for that :)

But if not Column, then definitely Col. C seems like a mistake! Okay to define an alias in your own code, but not something that should be in a library.

@tomjaguarpaw
Copy link
Collaborator Author

OK, I'm happy to discard the C option. If no one else comes out in favour of Col then I'll go with Column.

@c-lewis
Copy link
Collaborator

c-lewis commented Jul 16, 2014

As Daniel said, if someone finds their type signatures are getting
unwieldy, they can always create an alias.

On Wed, Jul 16, 2014 at 9:34 AM, tomjaguarpaw notifications@github.com
wrote:

OK, I'm happy to discard the C option. If no one else comes out in favour
of Col then I'll go with Column.


Reply to this email directly or view it on GitHub
#37 (comment)
.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants