Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Have one way to build static/karma.js #3599

Closed
johnjbarton opened this issue Dec 22, 2020 · 3 comments · Fixed by #3600
Closed

Have one way to build static/karma.js #3599

johnjbarton opened this issue Dec 22, 2020 · 3 comments · Fixed by #3600
Labels
released

Comments

@johnjbarton
Copy link
Contributor

I just discovered the hard way that static/karma.js can be created with

  1. grunt browserify or
  2. npm scripts/client.js build

It seems like grunt watch relies on the first and travis relies on the second.

I propose to remove grunt browserify

@devoto13 WDYT?
@devoto13
Copy link
Collaborator

I agree with grunt browserify removal. We should probably add watch mode support to the scripts/client.js at the same time as we remove Grunt counterpart to not reduce functionality. Do you want me to make a PR or do you want to look into it yourself?

And sorry that you had to learn it the hard way, I probably should have made the complete switch in a single commit instead of doing only part of the work.

PS The correct way to build the client it is outlined in the docs:

npm run build

@johnjbarton
Copy link
Contributor Author

If you use the watch feature please give a shot at the PR. I've not used it so would have to learn ;-)

devoto13 added a commit to devoto13/karma that referenced this issue Dec 23, 2020
@devoto13
chore(build): unify client bundling scripts
3ccb413 
Remove bundling logic from Grunt and introduce watch mode into the scripts/client.js. New script (`npm run build:watch`) allows to watch for the changes in client sources and bundle them automatically.

This also fixes a bug where `npm run build` could swallow errors and silently do nothing.

Fixes karma-runner#3599
@devoto13 devoto13 mentioned this issue Dec 23, 2020
Merged
johnjbarton pushed a commit that referenced this issue Dec 23, 2020
@devoto13
chore(build): unify client bundling scripts (#3600)
fe0e24a 
Remove bundling logic from Grunt and introduce watch mode into the scripts/client.js. New script (`npm run build:watch`) allows to watch for the changes in client sources and bundle them automatically.

This also fixes a bug where `npm run build` could swallow errors and silently do nothing.

Fixes #3599
@karmarunnerbot
Copy link
Member

🎉 This issue has been resolved in version 6.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

anthony-redFox pushed a commit to anthony-redFox/karma that referenced this issue May 16, 2023
@devoto13 @anthony-redFox
chore(build): unify client bundling scripts (karma-runner#3600)
b9c8b92 
Remove bundling logic from Grunt and introduce watch mode into the scripts/client.js. New script (`npm run build:watch`) allows to watch for the changes in client sources and bundle them automatically.

This also fixes a bug where `npm run build` could swallow errors and silently do nothing.

Fixes karma-runner#3599
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore(build): unify client bundling scripts devoto13/karma
3 participants
@johnjbarton @devoto13 @karmarunnerbot