Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sinon@1.17.5 breaks build 🚨 #2278

Merged
merged 1 commit into from
Jul 29, 2016
Merged

Conversation

greenkeeperio-bot
Copy link
Contributor

Hello lovely humans,

sinon just published its new version 1.17.5.

State Failing tests 🚨
Dependency sinon
New version 1.17.5
Type devDependency

This version is covered by your current version range and after updating it in your project the build went from success to failure.

As sinon is “only” a devDependency of this project it might not break production or downstream projects, but “only” your build or test tools – preventing new deploys or publishes.

I recommend you give this issue a high priority. I’m sure you can resolve this 💪

Of course this could just be a false positive, caused by a flaky test suite, or third parties that are currently broken or unavailable, but that would be another problem I’d recommend working on.

Do you have any ideas how I could improve these pull requests? Did I report anything you think isn’t right?
Are you unsure about how things are supposed to work?

There is a collection of frequently asked questions and while I’m just a bot, there is a group of people who are happy to teach me new things. Let them know.

Good luck with your project ✨

You rock!

🌴


The new version differs by 38 commits .

  • d24a1f1 1.17.5
  • 721801c 1.17.5: Update AUTHORS and Changelog
  • 05363cf Merge pull request #1110 from fatso83/release-improvement
  • 7446d42 Only run on Node >= 0.12 in Travis
  • 3640b99 Add prepublish steps to avoid including extra files
  • fc2f909 PR #1109: Simplify some logic in from #1108
  • 19e49f6 Merge pull request #1108 from fearphage/v1.17-progress-event-compliance
  • 24691cb Merge pull request #1102 from fearphage/v1.17-dont-treat-non-200s-as-errors
  • 95aa362 use xhr.progress (length of body/response) for progress event
  • 06cc2ef capture response length from setResponseBody
  • bf709a7 updated current tests to account for api changes
  • 54aa22f reverted tests
  • 35129e0 added xhr.error() method to simulate network errors
  • 3eb782d stopped treating non-200 responses as errors
  • 33ea740 copied XHR tests from master

There are 38 commits in total. See the full diff.


This pull request was created by greenkeeper.io.

Tired of seeing this sponsor message? ⚡ greenkeeper upgrade

@dignifiedquire dignifiedquire merged commit cbd44f3 into master Jul 29, 2016
@dignifiedquire dignifiedquire deleted the greenkeeper-sinon-1.17.5 branch July 29, 2016 20:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants