Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to the v2 npm lockfile. #3783

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .github/workflows/release.yml
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,7 @@ jobs:
with:
node-version: 14
cache: npm
- run: npm i -g npm@7
- run: npm ci
- run: npm run lint
- run: npm run build:check
Expand Down
3 changes: 3 additions & 0 deletions .github/workflows/test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,7 @@ jobs:
with:
node-version: 14
cache: npm
- run: npm i -g npm@7
- run: npm ci
- run: npm run commitlint -- --from `git merge-base origin/master $GITHUB_SHA`
- run: npm run lint
Expand All @@ -42,6 +43,7 @@ jobs:
with:
node-version: ${{ matrix.node }}
cache: npm
- run: npm i -g npm@7
- run: npm ci
- run: npm run test:unit
- run: npm run test:e2e
Expand All @@ -57,5 +59,6 @@ jobs:
with:
node-version: ${{ matrix.node }}
cache: npm
- run: npm i -g npm@7
- run: npm ci
- run: npm run test:unit
2 changes: 1 addition & 1 deletion docs/dev/02-making-changes.md
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ Here are some tips on how to set up a Karma workspace and how to send a good pul
$ git clone https://github.com/<your-username>/karma.git
$ cd karma
```
* Install for development
* Install for development (make sure to use NPM 7+ as otherwise installation will fail)
```bash
$ npm install
```
Expand Down
Loading