Enable graceful eviction in taint manager #2346
Merged
+184
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
karmada-bot
added
the
kind/feature
karmada-bot
added
the
size/L
RainbowMango
force-pushed
the
pr_add_graceful_evict_helper
branch
from
84a7e18 to
74dc4c4
Compare
8 tasks
|
/assign @Garrybest @XiShanYongYe-Chang |
Garrybest
suggested changes
Aug 8, 2022
graceful eviction only when feature gate is on. Signed-off-by: RainbowMango <qdurenhongcai@gmail.com>
RainbowMango
force-pushed
the
pr_add_graceful_evict_helper
branch
from
74dc4c4 to
2673a99
Compare
|
/lgtm |
RainbowMango
added
the
approved
|
[APPROVALNOTIFIER] This PR is APPROVED Approval requirements bypassed by manually added approval. This pull-request has been approved by: The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind feature
What this PR does / why we need it:
This PR enables graceful eviction in taint manager but only takes effect when the feature gate is enabled.
Which issue(s) this PR fixes:
Partof #2281
Special notes for your reviewer:
Does this PR introduce a user-facing change?: