Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug] Warning about google colab runtime could be a tad more helpful/precise (base_64) #37

Closed
davidefiocco opened this issue Jan 31, 2022 · 1 comment · Fixed by #38
Closed

[Bug] Warning about google colab runtime could be a tad more helpful/precise (base_64) #37

davidefiocco opened this issue Jan 31, 2022 · 1 comment · Fixed by #38
Assignees
@karolzak
Labels
bug Something isn't working documentation Improvements or additions to documentation

Comments

@davidefiocco
Copy link
Contributor

davidefiocco commented Jan 31, 2022 •
edited
Loading

Hi!

I think that in

ipyplot/ipyplot/__init__.py

Line 26 in ff64f4a

If images are not displaying properly please try setting `base_64` param to `True`.
the warning should refer to force_b64 (not base_64) to fix problems that may occur in Google colab.
davidefiocco added a commit to davidefiocco/ipyplot that referenced this issue Jan 31, 2022
@davidefiocco
Improve colab runtime warning message
cb0db0f 
This tries to address karolzak#37
@davidefiocco davidefiocco mentioned this issue Jan 31, 2022
Merged
@karolzak karolzak linked a pull request Jan 31, 2022 that will close this issue
Improve colab runtime warning message #38
Merged
karolzak pushed a commit that referenced this issue Jan 31, 2022
@davidefiocco
Fix Google Collab runtime warning message (#38)
3d32f3f 
This tries to address #37
@karolzak karolzak changed the title Warning about colab runtime could be a tad more helpful/precise (base_64) [Bug] Warning about google collab runtime could be a tad more helpful/precise (base_64) Jan 31, 2022
@karolzak karolzak self-assigned this Jan 31, 2022
@karolzak karolzak added bug Something isn't working documentation Improvements or additions to documentation labels Jan 31, 2022
@karolzak
Copy link
Owner

Good catch @davidefiocco, thanks for fixing it!

@davidefiocco davidefiocco changed the title [Bug] Warning about google collab runtime could be a tad more helpful/precise (base_64) [Bug] Warning about google colab runtime could be a tad more helpful/precise (base_64) Jan 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@karolzak karolzak

Labels
bug Something isn't working documentation Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Improve colab runtime warning message davidefiocco/ipyplot
2 participants
@davidefiocco @karolzak