PHP warning caused by duplicate property definition

[gyula-szabo]

Hello there!

The latest version of yii2-krajee-base breaks the file input widget under PHP 5.6.

Steps to reproduce the issue

1. Update yii2-krajee-base to latest release
2. Try to use the file input widget under PHP 5.6 with strict warnings enabled

Expected behavior and actual behavior

Following the steps above, this warning is thrown:

This is not the case using at least PHP 7.0, or even disabling strict warnings, but there can be (and there are, in fact) hosts where we cannot turn off the warnings even if we want to, so it would still be great to fix this.

Environment

Libraries

• yii2-krajee-base version: 1.9.4
• yii2-widget-fileinput version: 1.0.6

It seems to me that this needs to be fixed in this extension, and not in yii2-krajee-base, I hope I am correct in opening the issue here.

[cshehadi]

+1

[kartik-v]

Update to latest release and let know

[gyula-szabo]

It is now:

kartik\base\InputWidget and kartik\base\TranslationTrait define the same property ($i18n) in the composition of kartik\file\FileInput. This might be incompatible, to improve maintainability consider using accessor methods in traits instead. Class was composed

Both InputWidget and FileInput use TranslationTrait. Looks like PHP doesn't like this duplication. I removed the use TranslationTrait; line from FileInput to test the theory and it started working again.

[kartik-v]

Fixed

[rklvnoe]

The row with use TranslationTrait is still in the repositorty?
I still geht the error.

[kartik-v]

Not sure what you are checking. Latest release for you to update to is v1.0.7 and you can cross check the latest updated code for FileInput.

[amonline]

The line still exists in v1.0.7
https://github.com/kartik-v/yii2-widget-fileinput/blob/v1.0.7/src/FileInput.php