Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Accessibility Dimension Factors (Adjust Thresholds) #67

Open
Tracked by #15
carolinamayh opened this issue Jul 11, 2024 · 18 comments
Open
Tracked by #15

Accessibility Dimension Factors (Adjust Thresholds) #67

carolinamayh opened this issue Jul 11, 2024 · 18 comments
Assignees

Comments

@carolinamayh
Copy link
Collaborator

carolinamayh commented Jul 11, 2024

The five Accessibility Dimension factors required for the new version of the tool are already included in the previous version. However, the suggested thresholds for calculating the catchment areas for each factor have been updated. These changes need to be reflected under each respective factor. Please refer to the Excel file to review the suggested thresholds for each factor.

@ClaraIV
Copy link

ClaraIV commented Jul 15, 2024

@osundwajeff Hi Jeff, could you please confirm that you managed to adjust the thresholds to all existing factors in the Accessibility Dimension? I see them listed separately in the "Needs Review" and I'd like to close this ticket if it has been addressed. Thanks!

@osundwajeff
Copy link
Collaborator

Hi @ClaraIV, yes I managed to adjust them. The changes are in the current draft
PR

@dragosgontariu
Copy link
Collaborator

@osundwajeff Hi Jeff, I've tested the updates and none of the factors could be processed due to the attached errors:

Accessibility errors.zip

Could you investigate these? Thanks!

@osundwajeff
Copy link
Collaborator

Thanks for the feedback @dragosgontariu . I'll take a look at them.

@osundwajeff osundwajeff self-assigned this Jul 16, 2024
@osundwajeff osundwajeff added the Size 2 Give me 2 hours and I will have it for you label Jul 16, 2024
@osundwajeff
Copy link
Collaborator

Hi @dragosgontariu, I haven't been able to reproduce this error. Can we maybe have a session to look at it?

@dragosgontariu
Copy link
Collaborator

@osundwajeff Hi Jeff, Sure, let's have a call. Can you forward me an invite?

@osundwajeff
Copy link
Collaborator

@dragosgontariu I have a probable fix for those errors. I have pushed the changes to that PR, maybe you can test to see if you are still getting that issue

@dragosgontariu
Copy link
Collaborator

@osundwajeff Sure Jeff! Could you please indicate the path from where to download? Thanks!

@osundwajeff
Copy link
Collaborator

@dragosgontariu I think you can use it from this branch https://github.com/osundwajeff/GEEST/tree/dev-work

@javaftw
Copy link
Collaborator

javaftw commented Jul 19, 2024

@dragosgontariu Hi!
We are having some trouble replicating the "File not found" issue mentioned here, and would appreciate it if you could share as much of the following information as possible:

  • Versions (OS, QGIS, plugin, Python, etc)
  • File paths (installation, plugin, input, output, etc.)
  • Copy of offending source files
  • List of steps taken to raise error
  • Copies of stack traces/error reports
  • Notes on error consistency/reproducibility

@dragosgontariu
Copy link
Collaborator

dragosgontariu commented Jul 19, 2024

@osundwajeff

Hi Jeff,
As per your request please find below my response:

• Versions (OS, QGIS, plugin, Python, etc)

Windows 10 Pro
QGIS 3.32 – Lima
The updated plugin from the PR on 18.07.2024 – now I see there are other updates
Python 3.9.0
The ORS service is working with the API key provided by them

• File paths (installation, plugin, input, output, etc.)

The input files are attached here.
ETF.zip
FIN.zip
HLT.zip
PBT.zip
WTP.zip
Admin0.zip

The output directory it’s for testing.
The CRS used is EPSG: 32620

• Copy of offending source files
• List of steps taken to raise error
• Copies of stack traces/error reports
• Notes on error consistency/reproducibility

All the files generated in the process are attached here.
output.zip

@javaftw
Copy link
Collaborator

javaftw commented Jul 19, 2024

Thanks @dragosgontariu , this is very helpful indeed.
I would appreciate it if you could pass on some log files (typically found at C:\Users\<YourUsername>\AppData\Local\QGIS\QGIS3\profiles\default\QGIS\QGIS3\logs) that would have captured any error messages during the operation that fails to produce the .shp files. Thanks in advance.

@dragosgontariu
Copy link
Collaborator

Sure @osundwajeff
This is what I have there:

image

crashes.zip

@javaftw
Copy link
Collaborator

javaftw commented Jul 19, 2024

Ah, processing logging has to be explicitly enabled, which is wasn't. Nevermind. Thanks anyway.

@dragosgontariu
Copy link
Collaborator

@osundwajeff @ClaraIV @carolinamayh

Hi Jeff,

I tried to tag Michelle as well but I didn't find her in the list.

I noticed a new update in the repository and gave it a chance—the one where you can input all four shapefiles for Women’s Travel Patterns—and this time, all the factors in the Accessibility work. However, Women’s Travel Patterns itself doesn’t process to the end. I'm attaching the error message and temporary files.

I think this will ease your work and please narrow down the debugging process and focus on the WTP issue. Also, ensure that the thresholds for the entire Accessibility domain have been adjusted accordingly. After an internal review and QC, please let us know the status. Considering the above, when can we expect the Accessibility dimension to be ready?

Looking forward to your reply.

Thanks,
Dragos

error.txt
test 20072024.zip

@osundwajeff
Copy link
Collaborator

Here's @mvmaltitz

Hi @dragosgontariu, i was able to look into the issue and I worked on it. The team spearheaded by @javaftw will be able to review and test the updates. After that we will provide feedback.

@dragosgontariu
Copy link
Collaborator

@osundwajeff @mvmaltitz @ClaraIV @carolinamayh

Hi Jeff,

Could you please change the default thresholds for:

  1. WTF:

0 to 400 meters: 5
401 to 800 meters: 4
801 to 1200 meters: 3
1201 to 1500 meters: 2
1501 to 2000 meters: 1
Over 2000 meters: 0

currently is like this:

Image

  1. Health facilities:

0 to 2,000 meters: 5
2,001 to 4,000 meters: 4
4,001 to 6,000 meters: 3
6,001 to 8,000 meters: 2
8,001 to 10,000 meters: 1
Over 10,000 meters: 0

currently is like this:

Image

Thanks,
Dragos

@javaftw
Copy link
Collaborator

javaftw commented Jul 29, 2024

Review 29 Jul 2024

Women's Travel Patterns:
Image

Health Facilities:
Image

@mvmaltitz mvmaltitz removed the Size 2 Give me 2 hours and I will have it for you label Aug 15, 2024
@mvmaltitz mvmaltitz added this to the Indicator Enhancements milestone Aug 19, 2024
@mvmaltitz mvmaltitz mentioned this issue Sep 4, 2024
25 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants