impl_singleton: support _ and impl Trait in field types #359
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rationale 1: this is a step closer to removing widget-specific code Rationale 2: hidden "magic" bounds might be confusing
This is redundant
This case can be represented with Type::ImplTrait
This appears the simplest effective way of disabling lints globally. The disabled lints all concern code style and do not, in my opinion, improve the style.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This replaces the prior
for<X> Foo<X>style of inline generics.This macro is almost independent of KAS/widget-specifics now; the only exception is that a field with type
_(or omitted type) and attribute#[widget]has bound::kas::Widgetassumed. This is quite important to examples. Still, it should be possible to publish a variant without this feature toimpl-tools.