Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor, SPM support and exclude URLs based on a regex #220

Merged
merged 19 commits into from
Dec 6, 2021
Merged

Refactor, SPM support and exclude URLs based on a regex #220

merged 19 commits into from
Dec 6, 2021

Conversation

vGubriienko
Copy link
Collaborator

No description provided.

Emre Çiftçi and others added 19 commits September 30, 2020 10:52
refactor (#169)
4cf3b69 
- Deleted unnecessary self's
- Fixed indentations
- Deleted unnecessary override functions
@kasketis
fix typos
850e904
@kasketis
add spm package.swift and change version
8af8160
@tanpengsccd
make it work if embed in another pod (#187)
5b591ff 
Support cocoapods versions
@kasketis
change pod version and swift_versions
2a40bef
@kasketis
update device list
e20f69f
@kasketis
fix demo issues
fd0d786
@bd-jhunter
Correct view type cast in copyLabel function of NFXDetailsController_…
46b6b3f 
…iOS. (#202)
@kasketis
remove ip-retrieval request logging
79dab74
@petrosDemetrakopoulos
Regex ignore url implementation
8e9c144
@kasketis
fix typo
5d63122
@vGubriienko
Preparing to support SPM
3d45330
@vGubriienko @kasketis
Update README.md
3f165d9 
Co-authored-by: Christos Kasketis <kasketis@gmail.com>
@vGubriienko
Merge pull request #216 from vGubriienko/develop
9ad20cd 
Finishing SPM support
@petrosDemetrakopoulos @vGubriienko
Merge branch 'develop' into regex_ignore_url
53c7df5
@petrosDemetrakopoulos @vGubriienko
fixed matches function in regex
52e5f79
@petrosDemetrakopoulos @vGubriienko
- Added array for regex ignore urls
010c63c
@vGubriienko
Added different URL ignore methods
be4fb5b
@vGubriienko
Merge pull request #217 from kasketis/regex_ignore_url_support
cd73205 
Regex ignore url support
@kasketis kasketis self-requested a review December 6, 2021 21:12
@kasketis kasketis changed the title SPM & URL regex igmore Refactor, SPM support and exclude URLs based on a regex Dec 6, 2021
@vGubriienko vGubriienko merged commit 879a3ed into master Dec 6, 2021
@vGubriienko vGubriienko mentioned this pull request Dec 11, 2021
Closed
@skyparentile
Copy link

@vGubriienko Have you try to submit an app to AppleStore with SPM dependency?
Can apple reject submit?
Is there a procedure to remove the dependency when creating a "release" version for the appstore or is not necessary ?

@vGubriienko
Copy link
Collaborator Author

@skyparentile

Have you try to submit an app to AppleStore with SPM dependency?

No

Can apple reject submit?

Apple could reject any submit) But regarding SPM I don't think so. Netfox doesn't use any private API.

Is there a procedure to remove the dependency when creating a "release" version for the appstore or is not necessary ?

As I know currently there is no official way to do that. But there is exist some workarounds like: ProxymanApp/atlantis#38 . I suggest to use them if you choose SPM integration way.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kasketis kasketis kasketis approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@vGubriienko @skyparentile @kasketis @tanpengsccd @bd-jhunter @petrosDemetrakopoulos