Skip to content

Conversation

Turbo87
Copy link
Collaborator

@Turbo87 Turbo87 commented Sep 21, 2020

... instead of Mocha and Chai. And this introduces snapshot tests to assert on the coverage-summary.json results.

@Turbo87 Turbo87 requested a review from rwjblue September 21, 2020 17:26
Copy link
Collaborator

@rwjblue rwjblue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think will need a rebase to account for the tests in #290.

@Turbo87
Copy link
Collaborator Author

Turbo87 commented Sep 22, 2020

rebase done ✅

@rwjblue
Copy link
Collaborator

rwjblue commented Sep 22, 2020

I think the test-packages/index-test.js also needs to be updated to Jest syntax:

FAIL test-packages/index-test.js
  ● index.js › _getIncludes › _getIncludesForInRepoAddonDirectories › for an app with an inrepo addon under a custom path › instruments the inrepo addon

    TypeError: Cannot read property 'deep' of undefined

      510 |         it('instruments the inrepo addon', function () {
      511 |           const includes = Index._getIncludesForInRepoAddonDirectories();
    > 512 |           expect(includes).to.deep.equal([
          |           ^
      513 |             'my-app/utils/my-covered-util.js',
      514 |             'my-app/utils/my-uncovered-util.js',
      515 |             'my-in-repo-addon/utils/my-covered-util.js',

@Turbo87
Copy link
Collaborator Author

Turbo87 commented Sep 22, 2020

oh, whoops, totally missed that part 🤦‍♂️

@rwjblue rwjblue merged commit 053cbfa into ember-cli-code-coverage:master Sep 22, 2020
@Turbo87 Turbo87 deleted the jest branch September 22, 2020 17:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants