-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Nix packaging, instructions, and CI #38
Conversation
Co-authored-by: dvn <git@dvn.me>
Some crypto libraries missing for 32-bit x86.
github's artifact upload is being flaky and this is randomly failing, but we really don't need to be building everything for old versions of macos anyway. and we should probably replace 12 with 13, but, will find out if that actually works later...
i guess this just worked with alpine before because android takes longer
just in case more things could ever end up in nix_build
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't know how this so called Docker stuff works but looks fine to me.
There is contention over whether Nix flakes are better than doing Nix the old-way, but its probably what you want here because you get strong determinism.
Great work: I see also the same package name that appears to contain a hash:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not familiar with how Nix packaging works - this works, and I get a local build that matches the CI run:
https://github.com/katzenpost/katzen/releases/tag/test_ae1d8a819d5e30e9751caa39b77b5ef6f768e10d
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should vendorHash be constant?
The |
this builds on top of #31 - thanks @ehmry !
I don't really know what I'm doing with Nix but CI appears to be generating a package hash which matches what I get when I run it locally in podman, so, that's cool.