Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implementing Screen Reader Accessibility and Enhanced Error Message Handling with languages #58

Merged
merged 9 commits into from
Jul 7, 2023

Conversation

tech-andgar
Copy link
Contributor

(This is a kinda feature request so feel free to reject if you don't like!)

improvements to accessibility for screen readers, enhancing the use of alternative text for images, and position of image.
Source

In addition, the language of error messages has been refined for greater clarity and precision.

Note:
I'm sorry, I don't speak Japanese.
I have used an automatic translator for your language.
If there are any mistakes, please correct this file in your language.

@kawamataryo
Copy link
Owner

@andgar2010
Sorry for the late reply 🙇‍♂️
This is great! Thank you for your pull request.
I will review it.

@kawamataryo kawamataryo self-assigned this Jul 7, 2023
@kawamataryo kawamataryo added the enhancement New feature or request label Jul 7, 2023
src/lib/rewriteReadmeToIncludeCardText.ts Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
tech-andgar and others added 3 commits July 7, 2023 09:10
Co-authored-by: ryo <ba068082@gmail.com>
Co-authored-by: ryo <ba068082@gmail.com>
Co-authored-by: ryo <ba068082@gmail.com>
@tech-andgar
Copy link
Contributor Author

tech-andgar commented Jul 7, 2023

Dear @kawamataryo,

I want to thank you for your time and patience in reviewing my Pull Request. I understand that reviewing can take time, so I highly appreciate the attention you've given it.

Additionally, I am thankful for the corrections you have provided on some lines of code. If there is anything additional that needs adjusting, please let me know.

Lastly, I hope you find my Pull Request suitable and that it can be approved. Your feedback is invaluable and I am willing to make the necessary corrections to ensure it meets the project’s standards.

Once again, thank you for your response and review.

Warm regards,

@kawamataryo kawamataryo merged commit 417e7b9 into kawamataryo:main Jul 7, 2023
@tech-andgar
Copy link
Contributor Author

Already Releases updated?

@kawamataryo
Copy link
Owner

kawamataryo commented Jul 8, 2023

@andgar2010

I've just released v1.3.0. Thank you for your contributions! 🎉
https://github.com/kawamataryo/lapras-card-readme/releases/tag/v1.3.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants