-
Notifications
You must be signed in to change notification settings - Fork 313
refactor: CI #752
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: CI #752
Conversation
Merge Linter & Unit Tests into single config
* Bump linting tools * Update config to match behaviour
Good job Gavin. Could you also update the checkout Github Action Nevermind, I see you bumped it already |
Hey @AzisK, is there anything else I can do to help get this merged? |
@gavindsouza it looks good but before that could you look at my last comments about |
I can't find anything regarding those yet to be addressed. (Did you add comments that are in a Pending state? If so, you are yet to submit your review) Meanwhile, since black is moved to pre-commit, I think removing it from dev-requirements tracking is best. |
tox.ini
Outdated
@@ -1,13 +1,13 @@ | |||
[tox] | |||
envlist = py36,py37,py38,py39,pypy3 | |||
envlist = py38,py39,py310,py311,py312,pypy3 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you remove version 12 from here as well if it is unstable with Github Action actions/checkout@v4?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am also wondering why do we have pypy3
here if we are not running any tests with it. Is it easy to setup a test for it, too?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've removed 3.12
. About the pypy3
in the envlist, I'm not sure - I guess someone was using it in their development flows however I don't have a requirement on pypy so I haven't explored it
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it's best to leave pypy3 as is. It doesn't change anything for people who don't use it. If you care about it and have pypy3 setup on your local machine, it just works for you
RE: Meanwhile, since black is moved to pre-commit, I think removing it from dev-requirements tracking is best. I agree RE: I can't find anything regarding those yet to be addressed. (Did you add comments that are in a Pending state? If so, you are yet to submit your review) Yes, they have been in a pending state, sorry about that and thanks for the notice |
Everything looks good, thanks! I will merge the pull request but version bump and release will happen a little bit later. However, this mostly concerns the CI, so I believe the version is not even very important in this case |
Changes
pre-commit install
to setup your hooksFixes #748, #747