Refactor Configuration Handling #51
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DEVOPS-515 decrease_frequency_of_monitor
Support differing ee2 urls
This refactors the configuration handling to use a class instead of a dict. So this is a large change because this weaves through out the platform. There are a few minor flake8 fixes too but this is primarily what is needed to make the configuration change and fix tests.
Also fixed an error in the JobRunner init
…nto scanon/refactor_config
MrCreosote
reviewed
Jul 28, 2023
There was a problem hiding this comment.
same here re repetitive code
Co-authored-by: MrCreosote <MrCreosote@users.noreply.github.com>
Co-authored-by: MrCreosote <MrCreosote@users.noreply.github.com>
Co-authored-by: MrCreosote <MrCreosote@users.noreply.github.com>
…nto scanon/refactor_config
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This refactors the configuration handling to use a class instead of a dict. So this is a large change because this weaves through out the platform.
JobRunner/config.py add a Config class. This is initialized by the CLI tools or modules. The config object is then passed off to the other modules. Many of the tests also needed to be updated since they were initializing a configuration dict before.
There are a few minor flake8 fixes too but this is primarily what is needed to make the configuration change and fix tests.