Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of PR purpose/changes
This PR is to address the comments from Mallory:
_"Was making the globus button text blue and underline on hover intentional? Was this to combat the a11y issue? If it was not intentional, can we style it so it matches the other button?
Can we add an 8px margin to this row so it has just a little bit more breathing room?"_
To address accessibility, I wrapped the button with an anchor tag and made the button non-keyboard navigable. This provides the benefit of the globus button looking correct while also maintaining typical link functionality with keyboard navigation and screen readers.
Jira Ticket / Issue
https://kbase-jira.atlassian.net/browse/DATAUP-187
Testing Instructions
make test-frontend-unit
kbase-narrative
, open a new narrative, and navigate to the import panel. The row for the buttons now has a top margin of 8px and the buttons are keyboard (click in the import area first then use keyboard to navigate) and screen reader accessible.Dev Checklist:
Updating Version and Release Notes (if applicable)