Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DATAUP-187 Review edits #1880

Merged
merged 3 commits into from
Oct 22, 2020
Merged

DATAUP-187 Review edits #1880

merged 3 commits into from
Oct 22, 2020

Conversation

eamahanna
Copy link
Contributor

Description of PR purpose/changes

This PR is to address the comments from Mallory:
_"Was making the globus button text blue and underline on hover intentional? Was this to combat the a11y issue? If it was not intentional, can we style it so it matches the other button?

Can we add an 8px margin to this row so it has just a little bit more breathing room?"_

To address accessibility, I wrapped the button with an anchor tag and made the button non-keyboard navigable. This provides the benefit of the globus button looking correct while also maintaining typical link functionality with keyboard navigation and screen readers.

Jira Ticket / Issue

https://kbase-jira.atlassian.net/browse/DATAUP-187

  • Added the Jira Ticket to the title of the PR e.g. (DATAUP-69 Adds a PR template)

Testing Instructions

  • Execute make test-frontend-unit
  • To view the changes locally, execute kbase-narrative, open a new narrative, and navigate to the import panel. The row for the buttons now has a top margin of 8px and the buttons are keyboard (click in the import area first then use keyboard to navigate) and screen reader accessible.

Dev Checklist:

  • My code follows the guidelines at https://sites.google.com/truss.works/kbasetruss/development
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I have run Black and Flake8 on changed Python Code manually or with git precommit (and the travis build passes)

Updating Version and Release Notes (if applicable)

@coveralls
Copy link

coveralls commented Oct 21, 2020

Coverage Status

Coverage increased (+0.006%) to 16.983% when pulling da9d63e on DATAUP-187-review-changes into e4125e1 on truss.

Copy link
Contributor

@leia-sefkin leia-sefkin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks ok to me, changes make sense. The only thing I noticed is that when you hover over the Globus Button there's a small trailing -- outside the button itself. Not sure where this is coming from but maybe some overflow from the element? Super minor but hopefully easy to fix

Screen Shot 2020-10-21 at 9 33 32 AM

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@eamahanna
Copy link
Contributor Author

@leia-sefkin I was able to fix the little dash. It was from a default link hover style

Copy link
Member

@briehl briehl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look great, and works when tested out locally!

@eamahanna eamahanna merged commit 86f459d into truss Oct 22, 2020
@eamahanna eamahanna deleted the DATAUP-187-review-changes branch October 22, 2020 00:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants