BUG: Do not clear text value when default is used #43
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Clearing the text value when the desired value equals the default value causes an issue when using the control as the value for a parameter in an ngc call since the SubCallButton uses the text value of the control as the parameter value. In this scenario there is no way to use the default value as the settings actual value since the control sets the text to ''.
|
@adargel Good point, thanks for the PR! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Clearing the text value when the desired value equals the default value
causes an issue when using the control as the value for a parameter in
an ngc call since the SubCallButton uses the text value of the control
as the parameter value. In this scenario there is no way to use the
default value as the settings actual value (that I know of) since the control sets the
text to ''.
Thanks for the amazing work on qtpyvcp and probe_basic. It is very much appreciated.