Skip to content

Conversation

Peefy
Copy link
Contributor

@Peefy Peefy commented Aug 9, 2023

1. Does this PR affect any open issues?(Y/N) and add issue references (e.g. "fix #123", "re #123".):

  • N
  • Y

feat: add translations for index pages

image

2. What is the scope of this PR (e.g. component or file name):

  • code.json
  • src/pages/index.tsx

3. Provide a description of the PR(e.g. more details, effects, motivations or doc link):

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Other

4. Are there any breaking changes?(Y/N) and describe the breaking changes(e.g. more details, motivations or doc link):

  • N
  • Y

5. Are there test cases for these changes?(Y/N) select and add more details, references or doc links:

  • Unit test
  • Integration test
  • Benchmark (add benchmark stats below)
  • Manual test (add detailed scripts or steps below)
  • Other

@Peefy Peefy merged commit 51b22ed into kcl-lang:main Aug 9, 2023
@Peefy Peefy deleted the index-page-i18n branch August 9, 2023 13:03
@github-actions github-actions bot locked and limited conversation to collaborators Aug 9, 2023
Sumitwarrior7 pushed a commit to Sumitwarrior7/kcl-lang.io that referenced this pull request Dec 30, 2024
fix(resolve_var) fix resolver_var() to record used module
Recursively seach whole scope to lookup module object and record it as `used`
fix kcl-lang#132
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant