Skip to content

fix: for local var example code add more unit test cases #304

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 5, 2024
Merged

fix: for local var example code add more unit test cases #304

merged 1 commit into from
Mar 5, 2024

Conversation

Peefy
Copy link
Contributor

@Peefy Peefy commented Mar 5, 2024 •
edited
Loading

1. Does this PR affect any open issues?(Y/N) and add issue references (e.g. "fix #123", "re #123".):

  • N
  • Y

fix #302

fix: for local var example code add more unit test cases

2. What is the scope of this PR (e.g. component or file name):

  • blog/2023-05-30-vs-helm/index.md
  • examples/gitops/Makefile
  • examples/gitops/config/Makefile
  • examples/gitops/config/kubernetes_render.k
  • examples/test.sh
  • i18n/zh-CN/docusaurus-plugin-content-blog/2023-05-30-vs-helm/index.md

3. Provide a description of the PR(e.g. more details, effects, motivations or doc link):

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Other

4. Are there any breaking changes?(Y/N) and describe the breaking changes(e.g. more details, motivations or doc link):

  • N
  • Y

5. Are there test cases for these changes?(Y/N) select and add more details, references or doc links:

  • Unit test
  • Integration test
  • Benchmark (add benchmark stats below)
  • Manual test (add detailed scripts or steps below)
  • Other
  • examples/gitops/config/kubernetes_render_test.k

@Peefy
fix: for local var example code add more unit test cases
0501ce0 
Signed-off-by: peefy <xpf6677@163.com>
@Peefy Peefy mentioned this pull request Mar 5, 2024
Closed
zong-zhe
zong-zhe approved these changes Mar 5, 2024
View reviewed changes
Copy link
Contributor

@zong-zhe zong-zhe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Peefy Peefy merged commit 7387b14 into kcl-lang:main Mar 5, 2024
@Peefy Peefy deleted the fix-for-local-var-example-code branch March 5, 2024 07:30
@github-actions github-actions bot locked and limited conversation to collaborators Mar 5, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@zong-zhe zong-zhe zong-zhe approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Example Issue] kcllang/kcl:latest docker image has problems processing variables.
2 participants
@Peefy @zong-zhe