Skip to content

Conversation

shruti2522
Copy link
Contributor

1. Does this PR affect any open issues?(Y/N) and add issue references (e.g. "fix #123", "re #123".):

  • N
  • Y

2. What is the scope of this PR (e.g. component or file name):

kcl-lang/kcl-lang.io/blog/2024-04-30-newsletter

3. Provide a description of the PR(e.g. more details, effects, motivations or doc link):

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Other

4. Are there any breaking changes?(Y/N) and describe the breaking changes(e.g. more details, motivations or doc link):

  • N
  • Y

The current image for kcl.mod.lock syntax highlighting is outdated. I have replaced it with an updated image.

Before:
Screenshot from 2024-04-28 05-55-34

After:
Screenshot from 2024-05-02 17-54-56

5. Are there test cases for these changes?(Y/N) select and add more details, references or doc links:

  • Unit test
  • Integration test
  • Benchmark (add benchmark stats below)
  • Manual test (add detailed scripts or steps below)
  • Other

Copy link

vercel bot commented May 2, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
kcl-lang-io ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 2, 2024 2:14pm

@Peefy
Copy link
Contributor

Peefy commented May 2, 2024

CI failed

Signed-off-by: shruti2522 <shruti.apc01@gmail.com>

fixed ci errors

Signed-off-by: shruti2522 <shruti.apc01@gmail.com>

fix: update kclmod.lock.png for 2024-04-30-newsletter

Signed-off-by: shruti2522 <shruti.apc01@gmail.com>
@shruti2522 shruti2522 force-pushed the update-2024-04-30-newsletter branch from 2537747 to 4262eb3 Compare May 2, 2024 13:37
Copy link
Contributor

@Peefy Peefy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants