Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: make decorator document more simple #1095

Merged
merged 1 commit into from
Feb 29, 2024

Conversation

Peefy
Copy link
Contributor

@Peefy Peefy commented Feb 29, 2024

1. Does this PR affect any open issues?(Y/N) and add issue references (e.g. "fix #123", "re #123".):

  • N
  • Y
  • refactor: make decorator document more simple

2. What is the scope of this PR (e.g. component or file name):

  • kclvm/sema/src/builtin/decorator.rs

3. Provide a description of the PR(e.g. more details, effects, motivations or doc link):

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Other

4. Are there any breaking changes?(Y/N) and describe the breaking changes(e.g. more details, motivations or doc link):

  • N
  • Y

5. Are there test cases for these changes?(Y/N) select and add more details, references or doc links:

  • Unit test
  • Integration test
  • Benchmark (add benchmark stats below)
  • Manual test (add detailed scripts or steps below)
  • Other
  • kclvm/tools/src/LSP/src/hover.rs

Signed-off-by: peefy <xpf6677@163.com>
@Peefy Peefy added the semantic Issues or PRs related to kcl semantic and checker label Feb 29, 2024
@coveralls
Copy link
Collaborator

Pull Request Test Coverage Report for Build 8095570811

Details

  • 2 of 2 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.007%) to 71.898%

Totals Coverage Status
Change from base Build 8094539559: -0.007%
Covered Lines: 44474
Relevant Lines: 61857

💛 - Coveralls

@Peefy Peefy merged commit e9d0a1b into kcl-lang:main Feb 29, 2024
7 of 8 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Feb 29, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
semantic Issues or PRs related to kcl semantic and checker
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants